search

PAIR-code / what-if-tool

Source code/webpage/demos for the What-If Tool
https://pair-code.github.io/what-if-tool
Apache License 2.0
923 stars 170 forks source link

Change /bin/sh to /bin/bash in build_pip_package.sh #154

Closed abrandenb closed 3 years ago

abrandenb commented 3 years ago

Related to #34, #35

It seems that build_pip_package.sh requires pushd, which is unknown in sh and prevented me from building.

This commit allows me to build the package. If there is no good reason to use /bin/sh, I propose to explicitly require /bin/bash. Otherwise, I do not see a good way to build the package on a system without root access and default shell sh.

Let me know what you think!

jameswex commented 3 years ago

Makes sense, thanks @abrandenb . Can you also update the build_pip_package.sh in witwidget/pip_package?

abrandenb commented 3 years ago

Great that you agree @jameswex! 4b404aa66e0f0659357517345337f008c33b5477 should handle the witwidget.

adamjstewart commented 3 years ago

This solved an issue I was seeing when building on Ubuntu where sh -> dash. Without this, the build just hangs forever with no explanation as to what is wrong. Would love to see a 1.8.1 release with this patch added.

jameswex commented 3 years ago

We will release a new wit package after one upcoming change to support new Google Cloud Vertex models.