search

PATRIC3 / patric3_website

Legacy PATRIC Website (JBoss Portal Version)
MIT License
5 stars 2 forks source link

Genomes Tab: Sorting by Antimicrobial Resistance column gives an empty table #861

Closed chmao1 closed 8 years ago

chmao1 commented 8 years ago

genomelist

mshukla1 commented 8 years ago

Dustin, sorting is not working because antimicrobial_resistance is a multi value fields.

We need to either disable sorting or handle it gracefully, instead of table not loading.

dmachi commented 8 years ago

Yes, that column just needs to set sortable to false.

https://github.com/PATRIC3/p3_web/blob/master/public/js/p3/widget/GenomeGrid.js#L269-L278 https://github.com/PATRIC3/p3_web/blob/master/public/js/p3/widget/GenomeGrid.js#L269-L278

need to have “sortable: false” added as is done at:

https://github.com/PATRIC3/p3_web/blob/master/public/js/p3/widget/GenomeGrid.js#L88 https://github.com/PATRIC3/p3_web/blob/master/public/js/p3/widget/GenomeGrid.js#L88

If there are other multivalve fields, the same treatment should be done on them.

On Aug 19, 2016, at 12:57 PM, mshukla1 notifications@github.com wrote:

Dustin, sorting is not working because antimicrobial_resistance is a multi value fields.

We need to either disable sorting or handle it gracefully, instead of table not loading.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/PATRIC3/patric3_website/issues/861#issuecomment-241073245, or mute the thread https://github.com/notifications/unsubscribe-auth/AALobnLaJ2iID4cmrTY2JxLjg5IxQxiCks5qheBigaJpZM4Jn64V.

dmachi commented 8 years ago

Fixed all multivalue fields in the GenomeGrid