search

PCGen / pcgen

Main code and data development for pcgen program release
http://pcgen.org
GNU Lesser General Public License v2.1
431 stars 341 forks source link

codacy/checkstyle tab width #4107

Closed tildar closed 6 years ago

tildar commented 6 years ago

Checkstyle defaults to 8 wide tabs, but it seems the standard eclipse32_pcgen.xml sets up for 4 wide tabs.

I'm assuming that checkstyle should be adjusted.

I have attempted to modify the checkstyle.xml to count 4 wide tabs, but I'm just not having any luck.

This primarily affects the line length checks, and causes confusion when codacy tags lines as much much longer that what is seen in eclipse.

Maybe someone else will have better luck getting checkstyle set correctly?

LegacyKing commented 6 years ago

All files I reviewed have this:

<property name="tabWidth" value="4"/> Codacy pulls from the configuration file. Max line length is set to 80. Not sure if that is what you meant.

tildar commented 6 years ago

I eventually figured it out. forgot to close this.