PCGen / pcgen

Main code and data development for pcgen program release
http://pcgen.org
GNU Lesser General Public License v2.1
431 stars 341 forks source link

[BUG] master build slowtest failing #6361

Closed alanshutko closed 4 years ago

alanshutko commented 4 years ago

Describe the bug Six test cases in slowtest are failing

To Reproduce Steps to reproduce the behavior:

  1. git clone git@github.com:PCGen/pcgen.git
  2. ./gradlew clean build copyToOutput test compileSlowtest datatest pfinttest allReports buildDist

Expected behavior Tests should pass

Screenshots

DataLoadTest > [2] Pathfinder RPG for Game Masters FAILED org.opentest4j.AssertionFailedError: Errors encountered while loading Pathfinder RPG for Game Masters ==> expected: <> but was: at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:69) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:188) at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1146) at pcgen.persistence.lst.DataLoadTest.testLoadSources(DataLoadTest.java:137)

DataLoadTest > [3] 5e - System Reference Document FAILED org.opentest4j.AssertionFailedError: Errors encountered while loading 5e - System Reference Document ==> expected: <> but was: <Unconstructed Reference: Deity None, 5e did not have one Deity with 'Unselected' Group (found: 0)> at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:69) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:188) at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1146) at pcgen.persistence.lst.DataLoadTest.testLoadSources(DataLoadTest.java:137)

DataLoadTest > [8] Pathfinder RPG Core Supplements FAILED org.opentest4j.AssertionFailedError: Errors encountered while loading Pathfinder RPG Core Supplements ==> expected: <> but was: at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:69) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:188) at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1146) at pcgen.persistence.lst.DataLoadTest.testLoadSources(DataLoadTest.java:137)

pcGenGUISFmechanicTest > testCode() FAILED org.opentest4j.AssertionFailedError: Expected text value 'Athletics +24, Computers +34, Engineering +33, Medicine +29, Perception +29, Physical Science +28, Piloting +28, Profession (Maintenance Worker) +27, Sense Motive +6, Stealth +7, Survival +6' but was 'Athletics +24, Computers +34, Engineering +39, Medicine +29, Perception +29, Physical Science +28, Piloting +28, Profession (Maintenance Worker) +27, Sense Motive +6, Stealth +7, Survival +6' - comparing <list_mods ...>Athletics +24, Computers +34, Engineering +33, Medicine +29, Perception +29, Physical Science +28, Piloting +28, Profession (Maintenance Worker) +27, Sense Motive +6, Stealth +7, Survival +6 at /character[1]/skills[1]/list_mods[1]/text()[1] to <list_mods ...>Athletics +24, Computers +34, Engineering +39, Medicine +29, Perception +29, Physical Science +28, Piloting +28, Profession (Maintenance Worker) +27, Sense Motive +6, Stealth +7, Survival +6 at /character[1]/skills[1]/list_mods[1]/text()[1] ==> expected: but was: at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:40) at org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:218) at pcgen.inttest.PcgenFtlTestCase.runTest(PcgenFtlTestCase.java:115) at pcgen.inttest.game_starfinder.pcGenGUISFmechanicTest.testCode(pcGenGUISFmechanicTest.java:20)

pcGenGUIElwoodTest > testElwood() FAILED org.opentest4j.AssertionFailedError: Expected child nodelist length '1' but was '0' - comparing at /character[1]/weapons[1]/unarmed[1]/total[1] to at /character[1]/weapons[1]/unarmed[1]/total[1] ==> expected: but was: at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:40) at org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:218) at pcgen.inttest.PcgenFtlTestCase.runTest(PcgenFtlTestCase.java:115) at pcgen.inttest.game_modern.pcGenGUIElwoodTest.testElwood(pcGenGUIElwoodTest.java:36)

pcGenGUIIlyanaTest > testIlyana() FAILED org.opentest4j.AssertionFailedError: Expected child nodelist length '1' but was '0' - comparing at /character[1]/weapons[1]/unarmed[1]/total[1] to at /character[1]/weapons[1]/unarmed[1]/total[1] ==> expected: but was: at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:40) at org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:218) at pcgen.inttest.PcgenFtlTestCase.runTest(PcgenFtlTestCase.java:115) at pcgen.inttest.game_modern.pcGenGUIIlyanaTest.testIlyana(pcGenGUIIlyanaTest.java:35) Desktop (please complete the following information):

Character File Include a character *.pcg file that can be used to reproduce the issue.

Additional context output.txt

alanshutko commented 4 years ago

I'm going to close this issue and open up separate issues for individual sources, because they have different problems.