Open dlucchetti opened 7 months ago
I found a bug on the cuStateVec wrapper, on the definition of the RYY gate: https://github.com/PECOS-packages/PECOS/pull/55/commits/3e17bc01acedd0a4cf6f8d77aa1d84b0c98246c7
Perhaps it's worth doing a cherry-pick of this commit to this branch? Apologies, I should probably have created a PR for that bugfix on its own, rather than add it on a feature PR.
On an unrelated note: you might want to update the version requirement in the tests/integration/state_sim_tests/test_statevec.py
file, line 24. Alternatively, we could just remove that check from the test file, it is unnecessary since the pyproject.toml is already dealing with versioning, so we should just check whether it is installed or not.
@dlucchetti I'm happy to take this off your hands and add the change I suggested + make the CI checks pass for this PR. Give me a 👍 if that'd be helpful.
I ended up creating a separate branch, since there's some stuff in this PR I'm not sure I understand. The new PR is #64 and it includes most of the changes appearing here. The differences are:
init_helper
reset
"angle" in params
in the RZ
gate. I expect that, if this is necessary, we would need it in all of the single-qubit gate methods, not just the RZ
. If this is a fix that was needed for the use of HybridEngine
, have a look at #63 where I did a small change to parent_sim_classes.py
which appears to be enough to solve this.This looks like an older PR @dlucchetti do we want to still move forward with this? If so, looks like there are changes still to be made.
Update for the latest cuquantum library 0.24.0 interface. Tested on A100.