Open ciaranra opened 2 months ago
Oh boy CRA, this is a monster PR. I think it would help if you have some examples of the kinds of tests you would like the PR reviewers to run on this
Hehe, yeah it is a monster. Let me single out some smaller stuff for people to maybe concentrate on if they want to...
If you are up for reviewing this monster of a PR, here are some things that you can take a look at:
.github/workflows
. If you want you can see if all the testing and linting look right. The workflows look like they are doing their jobs properly... python-release.yml
is a bit of a beast, but it is mainly a utility for building distributions to be uploaded to pypicrates/pecos-qsims/src/sparse_stab.rs
(at the bottom of the file), in here python/tests/pecos/integration/state_sim_tests/test_stab_sims/
, and here python/tests/pecos/integration/test_random_circuits.py
. The Rust stabilizer simulator is probably better tested then the Python one. lolNew TODO:
Mostly just tried to work through the development section of the README.
make test-all
gave me:======== short test summary info ======== FAILED docs/api_guide/circuit_runners.rst::circuit_runners.rst FAILED docs/api_guide/decoders.rst::decoders.rst FAILED docs/api_guide/error_generators.rst::error_generators.rst FAILED docs/api_guide/qeccs.rst::qeccs.rst FAILED docs/api_guide/simulators.rst::simulators.rst FAILED docs/examples/creating_qecc_class.rst::creating_qecc_class.rst FAILED docs/examples/stab_code_verification.rst::stab_code_verification.rst ======== 7 failed, 2 passed, 1 warning in 0.82s ========
This should be resolved now. Just removing doc tests for now.
Alright, @qartik & @peter-campora. I have updated the makefile to make the .venv more of a "first class citizen" and updated the README appropriately (hopefully). Let me know if you still have issues.
I still need to figure out what is going on with this:
-pecos-rslib==0.6.0.dev6 +pecos-rslib==version = 0.6.0.dev6
Including Rust code for stabilizer simulator.
TODO:
test_random_circuits
(likely need to add force_outcome measurement)