search

PHP-Open-Source-Saver / jwt-auth

🔐 JSON Web Token Authentication for Laravel & Lumen
MIT License
729 stars 113 forks source link

I suggest replacing lcobucci/jwt with firebase/php-jwt which is more stable. #228

Open NeftaliYagua opened 11 months ago

NeftaliYagua commented 11 months ago

I have been carefully examining the code, and I always find that this package is difficult to maintain due to the instability of the main jwt service, so I consider that the most effective solution would be to replace it with firebase/jwt, if more developers support my proposal, I will work a branch to do the migration for the next version since the current package is no longer compatible with the latest versions of Laravel.

Please comment on this issue, with the purpose of joining the proposal or discussing the rejection and we can evaluate the pros and cons that can help make the best decision.

specialtactics commented 9 months ago

I think both seem to be reasonably actively developed, so I don't have any strong thoughts on this.

@NeftaliYagua could you elaborate on what specifically you are referring to when you are talking about instability of the lcobucci package? What is not compatible with the latest versions of laravel (ie. which specific package and which specific version of laravel) ?

Messhias commented 9 months ago

I have been carefully examining the code, and I always find that this package is difficult to maintain due to the instability of the main jwt service, so I consider that the most effective solution would be to replace it with firebase/jwt, if more developers support my proposal, I will work a branch to do the migration for the next version since the current package is no longer compatible with the latest versions of Laravel.

Please comment on this issue, with the purpose of joining the proposal or discussing the rejection and we can evaluate the pros and cons that can help make the best decision.

Take a test;

Okay, I don't see much reason to argue, there are 2 different packages with different pros and cons, what matters to me is: does it work or not?!

So before we even discuss whether the change is valid, we have to check whether the change will not affect what we already have that already works.

mfn commented 9 months ago

This overlaps a bit with https://github.com/PHP-Open-Source-Saver/jwt-auth/issues/73

OTOH, we currently have two providers (Lcobucci and Namshi).

IMHO "replacing" is the wrong start here.

First, someone needs to add a provider for firebase/php-jwt

Then we can talk how to proceed. Without a provider for it, this is vaporware 😅

NeftaliYagua commented 5 months ago

This overlaps a bit with #73

OTOH, we currently have two providers (Lcobucci and Namshi).

IMHO "replacing" is the wrong start here.

First, someone needs to add a provider for firebase/php-jwt

Then we can talk how to proceed. Without a provider for it, this is vaporware 😅

I'm going to try it and see how it turns out, however apparently they have an option for another provider, I'll try to see if that one works for me, because as you say the only relevant thing is whether it works or not. Now, regarding vaporware we are all voluntary collaborators, your comment seems aggressive to me, vaporware will be if you cool the will of anyone who comes to offer their collaboration and then prefers to dedicate themselves to other things.