Open jrfnl opened 6 months ago
When addressing this change, I believe there is a related bug, which should also be looked into and fixed: the use of context sensitive keywords as goto labels.
As things are, the context sensitive keywords layer in the tokenizer does not retokenize context sensitive keywords to T_STRING
when these are used as a goto label.
While this will always be a parse error, I still believe the keywords should be retokenized to T_STRING
for consistency. In the same way as context sensitive keywords used as the name of a class or (global) function are retokenized to T_STRING
, even though those usages would also result in a parse error.
Reminder for the tests:
callMe(label: $a, other: $b)
Repost from https://github.com/squizlabs/PHP_CodeSniffer/issues/3161 by @gsherwood: