search

PKBeam / Edda

A beatmap editor for the VR rhythm game Ragnarock
GNU General Public License v3.0
34 stars 8 forks source link

Error while importing SM map into Edda #113

Closed Brollyy closed 3 months ago

Brollyy commented 7 months ago

Reported by Loafspell over at Discord.

trying to convert an sm file i used for mapping but Edda seems to fail to import the note data correctly: it ends up as 0 notes but imported audio in Edda tested 1.2.3 and 1.2.4, both gave the same result here's the .sm file i made and the corresponding output in edda edda.zip stepmania.zip

i think i found the bug image oh wait turns out the program shits itself if you try importing ssc files despite Edda telling you it supports them

Brollyy commented 7 months ago

After initial investigation, there are two issues here:

  1. The notes don't import because the only BPM in the SM file is set at beat 0 and there's a positive offset - in this case the start of this BPM change falls on negative Ragnarock global beat and is completely skipped by converter.
  2. For SSC file, CREDIT tag in the header is empty and there's no CREDIT tag on the chart, which causes the error seen on the screenshot - we should just leave Mapper empty in this case, not fail the whole conversion process.
Brollyy commented 7 months ago

Reopening, as Loafspell reported that the issue with the notes is still happening in 1.2.5

Brollyy commented 3 months ago

Fix will be implemented in 1.2.6