Closed marcusramberg closed 1 year ago
Looks good. The spacing issue was done intentionally though, to make it look similar to TypeScript. Annoying that Nim complains about it though, so I guess I can accept this. Or we could throw ignore spacing issues pragmas around that part.
Looks good. The spacing issue was done intentionally though, to make it look similar to TypeScript. Annoying that Nim complains about it though, so I guess I can accept this. Or we could throw ignore spacing issues pragmas around that part.
I had a suspicion it might be intentional. I can update my PR if you prefer an ignore pragma instead.
Looks good. The spacing issue was done intentionally though, to make it look similar to TypeScript. Annoying that Nim complains about it though, so I guess I can accept this. Or we could throw ignore spacing issues pragmas around that part.
I tested
{.warning[Spacing]:off.}
around the offending code in messages.nim - but it's still throwing warnings, so not sure how to disable it. 😞
I think you need to use {.push.}
and {.pop.}
? But I might be wrong, I don't usually disable warnings
I think you need to use
{.push.}
and{.pop.}
? But I might be wrong, I don't usually disable warnings
I tried that variant as well without luck. Maybe it's better to just let it use the recommended formatting though?
Fixes about a million warnings like this by running
nimpretty
:as well as: