search

PR2 / pr2_common

45 stars 79 forks source link

Check for CATKIN_ENABLE_TESTING missing in pr2_description gtest declaration? #241

Closed gavanderhoorn closed 8 years ago

gavanderhoorn commented 9 years ago

Looks like CMakeLists.txt in pr2_description doesn't wrap the call to catkin_add_gtest(..) in a CATKIN_ENABLE_TESTING conditional block (here). On systems with no gtest, I believe this causes this package to fail the build.

gavanderhoorn commented 9 years ago

Relevant link: catkin 0.6.14 documentation » How to do common tasks » Package format 2 (recommended) » Configuring gtest for C++.

gavanderhoorn commented 9 years ago

Seems #238 already fixes this.

gavanderhoorn commented 9 years ago

Seeing as there is no issue for this, I'm actually going to keep this open until #238 is merged.

trainman419 commented 9 years ago

Sorry; I converted some of these packages to catkin before that standard was established.

gavanderhoorn commented 9 years ago

No problem.

Merging #238 should fix it.