search

PR2 / pr2_navigation

11 stars 25 forks source link

specify prefix for filter plugins #27

Closed v4hn closed 6 years ago

v4hn commented 7 years ago

The missing prefix has hazardous consequences due to a series of unfortunate events involving the filters and the laser_filters package..

See https://github.com/ros-perception/laser_filters/issues/50 for more details.

Fixes #26

k-okada commented 6 years ago

@furushchev will we be happy with this ? https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_pr2_robot/jsk_pr2_startup/jsk_pr2_sensors/tilt_laser_filters_for_gazebo.yaml

furushchev commented 6 years ago

@k-okada Yes, I think we also need to update the file.

k-okada commented 6 years ago

@furushchev oh, i mean do you approve this change? (but if so, i think our pr2 fail to run laser filters, is it correct?)

k-okada commented 6 years ago

I have talked to @furushchev online and confirmed this change is required and our pr2 is running without this future until now. https://github.com/jsk-ros-pkg/jsk_robot/pull/920