search

PREreview / rapid-prereview

An application for rapid, structured reviews of outbreak-related preprints
https://outbreaksci.prereview.org/
MIT License
13 stars 12 forks source link

Show login required modal on dashboard #161

Closed leonardosfl closed 4 years ago

leonardosfl commented 4 years ago

Fix #158

I think that someone forgot to add that 😄

It seems to be small change to be worth $100. If you want, you can change the price :)

IssueHunt Summary ### Referenced issues This pull request has been submitted to: - [#158: Dashboard UX: Add conditional asking users to login when attempting to add or request review](https://issuehunt.io/repos/208844948/issues/158) ---
leonardosfl commented 4 years ago

@harumhelmy I had no idea that it was going to be that simple :smile:.

If you think it's fair to add a couple of more related tasks to this, it would be great if you could also add a similar conditional to the Request | Review buttons on the PreprintCard component on the Dashboard (this behavior is also already on the homepage). Totally understand if you'd rather not, though.

I tested that yesterday and it was working. I'll take a look again

leonardosfl commented 4 years ago

@harumhelmy It's working. Is this the expected behavior? 76cbc1bf-0a41-472b-9c26-95f49106df1e

harumhelmy commented 4 years ago

Well darn, I could have sworn that wasn't working for me yesterday. 😅 Just ran it again locally and it's working great. Sorry about that, @leonardosfl !

That did make me think of another fix I think might be good if you're still down to work on it/for this issue's bounty (again, please only do it if you feel it's fair, you are welcome to yuck this and I'm happy to merge this fix). Could we not redirect users to the homepage when you're adding a new preprint from the dashboard? I haven't looked into it much, might just be a matter of adding a new route or something. Let me know and thank you as always ^_^

leonardosfl commented 4 years ago

@leonardosfl Sure. I'd love to help. I'll take a look.

leonardosfl commented 4 years ago

@harumhelmy It was quite some work 😄. Everything seems to be working as expected.

leonardosfl commented 4 years ago

@harumhelmy Hi, I've resolved the merge conflict.

harumhelmy commented 4 years ago

@leonardosfl Thank you so much for all this work! I haven't had time to thoroughly look and test yet, but will do so tomorrow AM EDT. I also spoke with PREReview leadership to see if we could get you a higher bounty reward because I've asked you so far beyond the initial stated issue here 😅

leonardosfl commented 4 years ago

@harumhelmy Thank you! I really appreciate it! 😄