search

PSC-PublicHealth / HERMES

0 stars 0 forks source link

SA #5: "failure in calling component validation algorithm" #99

Open jennBakal opened 6 years ago

jennBakal commented 6 years ago

Patrick said

Not sure why this occurred, but saw it a couple of times

image

happened for me as well when clicking done after adding various components, but too quickly to get a screenshot

jennBakal commented 6 years ago

this error is also referenced in Sarah Cox's RT HERMES issue 23265

Sarah said

In HERMES, when I click “Next Screen,” the following error message appears (screenshot below). However, when I click “Close” it allows me to move on without any issues.

ptrwed commented 5 years ago

There are a few "error" boxes that pop up, that are not fatal and allow the user to continue on as if nothing happened. It would be very good to get rid of these so that users don't get confused / think the model is messed up.

danielhertenstein commented 5 years ago

@ptrwed Do you know a way to reliably cause this error to appear?

pthompk3 commented 5 years ago

This issue is inconsistent. If a validation error occurs, a validation error will continue to occur if the user repeatedly goes forward to the Vaccine Dose Schedule page and then back to Add/Remove Components. But if the user edits the state of the components then the validation error won't persist. I was able to remove and re-add a vaccine and the error disappeared. The jqxhr.responseText part of the alert/error message appears to be an empty string when the error comes up, so it's not even clear what's causing it.

The only fix I really have in mind right now is to send the error message to console.error() instead of alert() so it doesn't confuse the user.