search

PSJahn / blurredwindow

GNU General Public License v3.0
9 stars 2 forks source link

[CONFLICT] Borderless Fullscreen #13

Open TheEpicRail opened 3 weeks ago

TheEpicRail commented 3 weeks ago

im not a fan of playing in windowed mode and was wondering if support for borderless fullscreen mods could be added

PSJahn commented 3 weeks ago

Could you please first explain the issues you're facing when using borderless fullscreen mods? Screenshots/Videos would be very much appreciated.

EnderKill98 commented 1 day ago

My assumption is that using mods such as concentration will basically will make the window fullscreen, but the checks like these will not trigger on it:

https://github.com/PSJahn/blurredwindow/blob/d6cae09e2c8002cd5863c87d01f0a7e12edfee89/src/main/java/de/psjahn/blurredwindow/mixin/ScreenMixin.java#L19

Or borderless fullscreen actually is internally triggered as isFullscreen() and the behavior of disabling blur in this case is not desired.

It probably boils down to a feature request to add configuration for these cases. E.g. a mod option like "Disable blur in fullscreen" to allow users to change it to their taste or when using mods that alter fullscreen behavior.