The survival rates object surv_rate parameter in OG-Core is incorrectly specified in that it is currently just an $S$-element list (see default_parameters.json). It would need to be a nested (2-dimensional) $S$-element list to be consistent with the mortality rates rho parameter, immigration rates, and population parameters. However, surv_rate is only used in parameters.py in OG-Core, and it shows up in testing input objects such as testing_params.json and create_params_inputs.pkl.
We propose that we make the following changes to OG-Core:
Remove the surv_rate object from default_parameters.json
Recode line 578 of parameters.py so that surv_rate is just equal to 1 - rho. This way surv_rate does not have to come from a country calibration demographics.py.
Fix the tests that depend on surv_rate being present.
This will require similar changes to be made to the country calibrations (e.g., OG-USA, OG-ZAF):
Update the rho parameter in og[cntry]_default_parameters.json
Remove the surv_rate parameter in og[cntry]_default_parameters.json
Remove surv_rate from the output of demographics.py
jdebacker
commented
1 year ago
The survival rates object
surv_rateparameter inOG-Coreis incorrectly specified in that it is currently just an $S$-element list (seedefault_parameters.json). It would need to be a nested (2-dimensional) $S$-element list to be consistent with the mortality ratesrhoparameter, immigration rates, and population parameters. However,surv_rateis only used inparameters.pyinOG-Core, and it shows up in testing input objects such astesting_params.jsonandcreate_params_inputs.pkl.We propose that we make the following changes to
OG-Core:surv_rateobject fromdefault_parameters.jsonparameters.pyso thatsurv_rateis just equal to 1 -rho. This waysurv_ratedoes not have to come from a country calibrationdemographics.py.surv_ratebeing present.This will require similar changes to be made to the country calibrations (e.g., OG-USA, OG-ZAF):
rhoparameter inog[cntry]_default_parameters.jsonsurv_rateparameter inog[cntry]_default_parameters.jsonsurv_ratefrom the output ofdemographics.pycc: @jdebacker