Closed jdebacker closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
1331b6a
) 80.52% compared to head (8fbbb9c
) 80.72%.
@jdebacker. This looks great. I ran the run_ogcore_example.py
script on my local machine to make sure the TPI worked and converged. I will merge this as soon as the final tests pass.
You might consider updating the version to 0.11.2 in setup.py
, ogcore/__init__.py
, and adding a CHANGELOG.md
entry that includes both the description at the top of the document and the GitHub compare hyperlink at the bottom of the document.
@rickecon Hold off. I want to try to figure out why the first period resource constraint isn't being satisfied and I think it's coming from demographics.py
. I'm still testing to find exact reason and will follow up here when I find it.
@jdebacker. Where is this error being manifest? Are you looking at the full TPI output after a run?
@rickecon asks:
Where is this error being manifest? Are you looking at the full TPI output after a run?
Yes. I need set ENFORCE_SOLUTION_CHECKS = False
in TPI.py
so that there's not an assertion raised before the output is saved. But when I do that and then look at the resource constraint errors along the time path, the only period with an error in excess of our tolerance is the first period.
@jdebacker. There is currently one test failing in test_demographics.py::test_custom_series()
.
@jdebacker. Thanks for this PR. Looks great. Merging.
This PR updates the
demographics.py
module to:get_pop_objs()
function over the full transition path of T+S periods (except those that apply only to a single period).Addresses Issues #900 and #899