Closed jdebacker closed 3 months ago
Attention: Patch coverage is 30.76923%
with 54 lines
in your changes missing coverage. Please review.
Project coverage is 72.44%. Comparing base (
0261fbf
) to head (3da5b4a
).
Currently tests pass on Mac OS, fail on Linux (not yet run on Windows). Test failure is with the SSE from the regressions for the HSV functions. These are computed via simple matrix operations and thus I'm surprised there is any difference across platforms. @rickecon Any ideas why dot products would not be identical across platforms?
@rickecon This PR is ready for your review.
The changes to starting values (which apply to the GS and DEP functions only) are to estimate the specified tax functions for all ages via a global optimizer (in this case, scipy.optimize.differential_evolution
), then use these parameter estimates for the initial guess for the first age group. Following that, the parameter estimates for each age are used as starting values for the next age.
@jdebacker. The Linux/Python 3.10 test seems to be stalled out. I wonder what is going on with the tests. I am just waiting for these all to pass. I approved all the code changes.
@jdebacker. This looks great and all checks have passed. Merging.
This PR will make the following changes: