PSLmodels / OG-USA

Overlapping-generations macroeconomic model for evaluating fiscal policy in the United States
https://pslmodels.github.io/OG-USA/
Creative Commons Zero v1.0 Universal
19 stars 34 forks source link

[DO NOT MERGE] Add windows to build_and_test.py #109

Closed rickecon closed 2 months ago

rickecon commented 2 months ago

This PR tests to see if adding windows-latest to the build_and_test.yml tests will work now that we are only testing Python 3.10 and 3.11.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.35%. Comparing base (3135391) to head (c2b142c).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/109/graphs/tree.svg?width=650&height=150&src=pr&token=XOLXIKEL86&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels)](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) ```diff @@ Coverage Diff @@ ## master #109 +/- ## ======================================= Coverage 75.35% 75.35% ======================================= Files 11 11 Lines 852 852 ======================================= Hits 642 642 Misses 210 210 ``` | [Flag](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/109/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PSLmodels/OG-USA/pull/109/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | `75.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#carryforward-flags-in-the-pull-request-comment) to find out more.
rickecon commented 2 months ago

This is stuck on Windows again. I went through build_and_test.py, environment.yml, and setup.py to make sure they were in line with their corresponding files in OG-Core, which works on windows-latest. But these fixes do not seem to be working. I am going to let these GH Action CI run overnight. See Issue #78.

rickecon commented 2 months ago

@jdebacker. Still doesn't work. I am closing this.