current git HEAD is not picking up inline_keys from same firmware image.

PSPReverse / PSPTool

Display, extract, and manipulate PSP firmware inside UEFI images

GNU General Public License v3.0

612 stars 62 forks source link

current git HEAD is not picking up inline_keys from same firmware image. #51

Open hanetzer opened 1 year ago

hanetzer commented 1 year ago

Asrock X370 Killer Sli/AC, bios image X370KLA6.00 psptool 2.6, as installed via pip install psptool, picks up many instances of inline_keys ec478c01196eea7afda65a00f85aa10e48cc6a7e, does not, and instead marks what 2.6 would show as either verified(xxxx) or inline_keys(xxxx) as key_missing(xxxx).

hanetzer commented 1 year ago

a bisect (probably faulty, as not every commit is runnable) between ec478c0 and the 2.5 tag shows 0bda1bd875236c0d87070290cba84c670c110605 to be the bad commit, which makes sense, it touches on the crypto handling side as well as adding entry types.

cwerling commented 2 months ago

Memo: The bug might be that inline keys that happen to have the same ID as the file itself are not shown. We need to fix this.