search

PSeitz / yamaha-nodejs

A node module to control your yamaha receiver
MIT License
123 stars 32 forks source link

some extensions #10

Closed soef closed 8 years ago

soef commented 8 years ago

discovery also works on windows

PSeitz commented 8 years ago

Thanks, that works. What is the waitForNotify function for?

soef commented 8 years ago

The waitForNotify function is to be notified, if the yamaha device was removed from power. If you call that function the callback is called when a notify messae ist send by the yamaha receiver 10-20 seconds after it gets back power. So you don't neet to try to reconnect when the yamaha device is powerless.

soef commented 8 years ago

Can you please take care of the possibility to not catch request exceptions? My way was to use dontCatchRequestErrors. Otherwise the application will get a different exception because of a call to toString from a null object.

PSeitz commented 7 years ago

I added a catchRequestErrors flag, which is on true by default (97d7345) The waitForNotify seems more like a general purpose query and not something related to the yamaha discovery/api