Can we make PRs that use http requests?

PSeitz / yamaha-nodejs

A node module to control your yamaha receiver

MIT License

123 stars 32 forks source link

Can we make PRs that use http requests? #32

Open alanbacon opened 4 years ago

alanbacon commented 4 years ago

There is a certain feature I wanted to make a PR for, but the feature only works over HTTP, and not with the XML interface.

Can you see a problem with this? Are you trying to support devices that don't support the JSON API?

alanbacon commented 4 years ago

Actually managed to work this out using XML, but I'm still interested in the answer to this question

PSeitz commented 4 years ago

JSON and XML are both HTTP, just different formats. Older receivers support only XML, newer support both, so XML is preferable for compatiblity. If there is something only available for JSON, I would not mind integrating it, but I can't test it, because my receiver is too old :)