search

PX4 / PX4-Autopilot

PX4 Autopilot Software
https://px4.io
BSD 3-Clause "New" or "Revised" License
8.47k stars 13.5k forks source link

pthread exit #14289

Open ToppingXu opened 4 years ago

ToppingXu commented 4 years ago

https://github.com/PX4/Firmware/blob/master/src/drivers/uavcan/uavcan_servers.cpp#L577

shouldn't here be _subnode_thread_should_exit = true after thread exit

julianoes commented 4 years ago

FYI @pavel-kirienko

pavel-kirienko commented 4 years ago

I suppose it was implemented to support restarting the thread afterwards. By the time the flag is reset the thread is already stopped so it has no effect. I don't think it's a mistake.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.