search

PX4 / PX4-Autopilot

PX4 Autopilot Software
https://px4.io
BSD 3-Clause "New" or "Revised" License
8.58k stars 13.56k forks source link

WIP: Upstream mmc5616 driver #24014

Open kraln opened 1 week ago

kraln commented 1 week ago

Solved Problem

Support for Memsic MMC5616 Mag Sensor

Solution

Changelog Entry

For release notes:

Feature MMC5616 Support

Test coverage

dagar commented 1 week ago

At a glance this looks fine, but the first thing is to cleanup the code style. You can do this automatically with astyle.

image

Have you tested the driver on actual hardware?

kraln commented 1 week ago

Have you tested the driver on actual hardware?

Yes, with 1.14 though. Before marking this PR as ready I'll get trunk going and attach a log.

kraln commented 1 week ago

At a glance this looks fine, but the first thing is to cleanup the code style. You can do this automatically with astyle.

Will do

mrpollo commented 6 days ago

This error from CI seems to b real https://github.com/PX4/PX4-Autopilot/actions/runs/11957592224/job/33335181227?pr=24014#step:8:12059