PacktPublishing / Mastering-Graphics-Programming-with-Vulkan

MIT License
526 stars 72 forks source link

Automatically download 3D models #2

Closed corporateshark closed 1 year ago

corporateshark commented 1 year ago
theWatchmen commented 1 year ago

Just to confirm, with this change users will have to run git submodule update --init before being able to run the bootstrap script?

corporateshark commented 1 year ago

Right. Or they can clone the entire repo just like this right from the get-go:

git clone --recurse-submodules https://github.com/PacktPublishing/Mastering-Graphics-Programming-with-Vulkan

theWatchmen commented 1 year ago

Cool. We'll wait to merge this until after the release of the book. I know most people will be able to figure it out, but this change would create a divergence with the instructions in the book and we'd like to avoid confusion :)

corporateshark commented 1 year ago

I think this solves the issue #4

corporateshark commented 1 year ago

@theWatchmen it looks like there's some strong demand for this.

theWatchmen commented 1 year ago

Thanks for this Sergey! I updated the README to include the clone instructions :)