PalisadoesFoundation / talawa-admin

Admin portal for the Talawa Mobile App. Click on the link below to see our documentation
https://docs.talawa.io/
GNU General Public License v3.0
148 stars 614 forks source link

Bug : Simplify error messages for user at Talawa User Portal #2464

Open bandhan-majumder opened 3 hours ago

bandhan-majumder commented 3 hours ago

Describe the bug In Talawa User portal when the user tries to update information with empty or invalid data, error in not user friendly way appears. Makes it hard to understand the user what required fields they are missing or giving an invalid data into.

To Reproduce Steps to reproduce the behavior:

  1. Go to Talawa User Portal
  2. Go to settings
  3. Submit data in invalid or empty format
  4. Click on save changes

Expected behavior Error should come one by one in a user friendly format.

Actual behavior

Variable "$phoneNumber" got invalid value ""; Value is not a valid phone number of the form +17895551234 (7-15 digits): Variable "$grade" got invalid value ""; Value "" does not exist in "EducationGrade" enum. Variable "$empStatus" got invalid value ""; Value "" does not exist in "EmploymentStatus" enum. Variable "$maritalStatus" got invalid value ""; Value "" does not exist in "MaritalStatus" enum.

Screenshots image

Additional details Add any other context or screenshots about the feature request here.

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

github-actions[bot] commented 3 hours ago

Congratulations on making your first Issue! :confetti_ball: If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

bandhan-majumder commented 3 hours ago

I would like to work on this issue. And please clarify my doubt that my changes should be pushed against develop or develop-postgres branch cause talawa-api's develop-postgres branch is not ready yet.