search

PaloAltoNetworks / pan-os-codegen

Generator for pango SDK and panos Terraform Provider
MIT License
4 stars 0 forks source link

DiffSuppress strings #76

Open migara opened 7 months ago

migara commented 7 months ago

We need a method to perform DiffSuppress

For example https://github.com/PaloAltoNetworks/pan-os-codegen/issues/77

shinmog commented 7 months ago

I feel like diff suppression like what I have in my mind is not possible.

What I was after was a way to allow users to configure audit comments in their plan file, but that changing comment would not show as something to be updated with using terraform plan.

After lots of searching, it seems like the best bet for accomplishing this, if it was possible, would be plan modifiers, but the documentation around plan modifiers seems to explicitly call out that changing the configured value is not allowed, of sorts..?

The logic in the code is already smart enough, without any further additions or changes, to do 0 update operations if neither the specs of the rules need to be changed nor the positioning of the rules. Since changing the timeout of a resource also results in a plan diff with terraform plan, perhaps it's best to just let the dream of "allowing users to change params in their plan files resulting in terraform plan showing nothing needs to be done" go.

If that is the case, then it's fine to just close this issue out.