PaloAltoNetworks / terraform-aws-vmseries-modules

Terraform Reusable Modules for VM-Series on AWS
https://registry.terraform.io/modules/PaloAltoNetworks/vmseries-modules/aws
MIT License
40 stars 49 forks source link

fix(module/asg): Catch index error while acquiring IP address for NIC #409

Closed sebastianczech closed 1 year ago

sebastianczech commented 1 year ago

Description

PR delivers fix for index error while acquiring IP address for network interfaces of VM-Series instance, which contains only 1 dataplane NIC and there is no dedicate untrust interface.

IP of untrust interface is used while registering and deregistering IP in target groups for centralized design, so in case of untrust IP is None, functions elbv2_client.register_targets and elbv2_client.deregister_targets could fail. Because of that additional catching of exceptions was added.

Motivation and Context

407

How Has This Been Tested?

Code was tested by deploying autoscaling examples in one-arm design (1 dataplane network interface).

Moreover registering and deregistering was checked by deploying autoscaling example for centralized design.

Types of changes

Checklist