search

PaloAltoNetworks / terraform-provider-panos

Terraform Panos provider
https://www.terraform.io/docs/providers/panos/
Mozilla Public License 2.0
87 stars 69 forks source link

migrate to more recent terraform-plugin-sdk #377

Open freedge opened 1 year ago

freedge commented 1 year ago

Is your feature request related to a problem?

indeed related to a problem, panos_address_objects is horribly slow with a large number of addresses One of the reason is https://github.com/hashicorp/terraform/issues/32940 Other reason come from the terraform-provider-panos process exec'ed from terraform, it spends considerable time computing diffs. I dug a bit and there are improvements doable in terraform-plugin-sdk such as https://github.com/hashicorp/terraform-plugin-sdk/pull/1181 but it's not really doable without first migrating to a recent version of terraform-plugin-sdk. The terraform-provider-panos main branch currently uses terraform-plugin-sdk v1.17.2 from 2 years ago.

Describe the solution you'd like

Migrate to a more recent version of terraform-plugin-sdk so we can benefit from fixes and maybe submit some more.

Describe alternatives you've considered

not using panos_address_objects or reducing the set size as suggested in the doc

Additional context

terraform plan and apply take dozen of minutes and we are trying to improve this.

Note there is some migration work to do, for example github.com/hashicorp/terraform-plugin-sdk/helper/hashcode does not exist anymore.

There are more info on the migration steps in https://github.com/hashicorp/terraform-plugin-sdk/pull/1181#issuecomment-1489271586

welcome-to-palo-alto-networks[bot] commented 1 year ago

:tada: Thanks for opening your first issue here! Welcome to the community!