search

PalouseRobosub / robosub_simulator

Robosub Simulator using Gazebo7
4 stars 0 forks source link

Gate task unit test #99

Closed Sindorman closed 6 years ago

Sindorman commented 6 years ago

Implement a way for either simulator to detect when sub passed the gate or make a unit test implicitly detect it based on it's location/position.

skallaher commented 6 years ago

This issue belongs in the Robosub repo.

Sindorman commented 6 years ago

@skallaher I haven't researched it yet, but I expect it to involve changes in simulator. For example a script that reads/detects position of sub in simulator, and checks it relative to the box of exit side of gate.

skallaher commented 6 years ago

The test itself can listen to the output from Gazebo and get the position of any and all models in the environment. This includes the gate and submarine. There should be no need to make changes to the simulator.

Sindorman commented 6 years ago

But it will be probably needs to be placed in robosub_simulator repository, because it will not run on the sub itself?

skallaher commented 6 years ago

There isn't a clear cut answer to this. Having the tests in the robosub repo also makes sure that they are available to run when the build server is run. In addition, this keeps the tests near the source they are testing. From what I can tell, unless @irwineffect knows otherwise, this is merely a design decision.