Allow an `on_update` as well as a `_RecordUpdater` - Githubissues

PandABlocks / PandABlocks-ioc

Create an IOC from a PandA

Apache License 2.0

1 stars 5 forks source link

Allow an `on_update` as well as a `_RecordUpdater` #121

Open evalott100 opened 5 months ago

evalott100 commented 5 months ago

In https://github.com/PandABlocks/PandABlocks-ioc/blob/8e25d64cc97cfbf242a84c6ccbe600a39ed41c41/src/pandablocks_ioc/ioc.py#L663-L682

A record updater is created to send data back to the panda.

Nowhere in the code passes on_update_name so this should be removed.
We should allow for the passing of a seperate argument record_updater, which can be merged with the passed in on_update.
We should allow for records with their own on_update which aren't _RecordUpdater.updates to also be given a _RecordUpdater.

AlexanderWells-diamond commented 5 months ago

Nowhere in the code passes on_update_name so this should be removed.

I added that as defensive code in case we ever do use it. If someone were to use it they would likely have an unexpected result, as the code would break in an unrelated place. I'm ok with removing it as long as this sort of protection is still available; if we change how the RecordUpdater is created/passed that will probably handle it.