PandaScience / FortySecondsCV

A highly customizable and improved version of Carmine Spagnuolo's Twenty Seconds Curriculum Vitae.
BSD 3-Clause "New" or "Revised" License
213 stars 66 forks source link

Some suggestions #1

Closed Bertbk closed 5 years ago

Bertbk commented 5 years ago

Thanks for your great template! I now use it for my résumé and it's just perfect!

As I modified your template a little bit, I was wondering if these changes could interest you and the users of the template (I can do a PR or whatever):

  1. Add option for LuaLatex (not only XeTeX)
  2. Profil Picture is no more mandatory
  3. Following 2., peronnal information on left sidebar of the first page are mandatory and the compilation breaks down if missing one of it:
    \newcommand*{\cvbirthday}[1]{\renewcommand{\cvbirthday}{#1}}
    \newcommand*{\cvaddress}[1]{\renewcommand{\cvaddress}{#1}}
    ...

    Instead of one command per data, I merged them in a common command \addcvdata for which we have to give the icon and the text:

    \newcommand*{\personnaldata}{}
    \newcommand{\addcvdata}[2]{\apptocmd{\personnaldata}{\circleicon{#1} & #2\\}{}{}}

    The command personnaltable is then adapted obviously

  4. FontAwesome is great but misses the AcademicIcons, which I added as a Require Package.
PandaScience commented 5 years ago

I'm glad you like it. I have a local version with a bunch of further changes/features lying around for almost 2 months now and couldn't find the time to review again and commit since I'm too busy with my physics code. However, I will definitely add your suggestions. You're welcome to create a pull request, then I will try to review the stuff within the next few weeks.

Bertbk commented 5 years ago

Thanks for your answer. I just submitted a PR.

PandaScience commented 5 years ago

So, I finally found some time to review your changes. Thank you very much for the PR #2! Here some notes:

I also had a look at your CV at cnrs.fr and as far as I can see, with all new features you should be able to reproduce that pdf with ease - and fix the width of your github icon en passant :wink:. So I'm going to close this issue.