Panfactum / stack

The Panfactum Stack
https://panfactum.com
Other
16 stars 5 forks source link

fix: ss not found in MacOS #69

Closed wesbragagt closed 4 months ago

wesbragagt commented 4 months ago

Adds a check before using ss and fallsback to netstat. This allows MacOS users to use the pf-buildkit command.

Fixes this issue: https://github.com/Panfactum/stack/issues/68

fullykubed commented 4 months ago

Good find!

However, this fix has some downsides:

Both of these are also problems in the original implementation as well.

I have taken the fix a different direction using lsof which should have the same behavior on all platforms. I have also added it to the devenv.

Thank you for this though as it helped provide a foundation for exploring the solution space.