search

PaperMC / Paper

The most widely used, high performance Minecraft server that aims to fix gameplay and mechanics inconsistencies
https://papermc.io/
Other
9.73k stars 2.27k forks source link

jukebox still playing after broken #9972

Open aabssmc opened 10 months ago

aabssmc commented 10 months ago

Expected behavior

to stop playing when being broken

Observed/Actual behavior

still playing when broken

Steps/models to reproduce

place a juke box spam it with a bunch of music discs

https://github.com/PaperMC/Paper/assets/53542804/3a9d801a-73ea-4277-8fa9-a67528f6464d

Plugin and Datapack List

spark, viaversion, viabackwards

Paper version

Paper version git-Paper-290 (MC: 1.20.2) (Implementing API version 1.20.2-RO.1-SNAPSHOT) (Git: f186318)

Other

No response

Machine-Maker commented 10 months ago

I cannot reproduce this. Try without the via plugins? It looks like from your video, it doesn't have a record in it when you break, so it doesn't stop the music. The music stop is just a packet sent when a jukebox is broken that has a record in it, so some state somewhere is being desynced.

It's possible I'm not clicking fast enough, but I was doing in creative so I didn't need to switch hands, just put in disc, and pop it out. But always when I stopped and the music was still playing, breaking the jukebox dropped the disc and stopped the music.

KioProject123 commented 10 months ago

It also happens in single player, you just need to click fast enough. You can map the right mouse button to Space and then hold Space for super fast clicks.

https://github.com/PaperMC/Paper/assets/61594596/46d7d470-1853-4092-8a9b-4cc162aca4a3