PapillonApp / Papillon

Une alternative open source aux applis de vie scolaire. L'allié de tous les étudiants. Le futur de l'éducation numérique libre et ouverte.
https://papillon.bzh
GNU General Public License v3.0
114 stars 42 forks source link

feat: Compatibilité SDK 52 d'Expo #368

Closed Kgeek33 closed 1 week ago

Kgeek33 commented 1 week ago

🚀 Nouvelle Pull Request

Proposez vos modifications pour améliorer Papillon

Informations importantes

Merci de vous référer à la documentation sur la contribution si vous avez des questions à propos des pull requests (https://gitbook.getpapillon.xyz/organisation/outils-internes/github)

Checklist d'avant pull request

Veuillez cocher toutes les cases applicables en remplaçant [ ] par [x].

Changelogs proposés

Informations supplémentaires

...

Kgeek33 commented 1 week ago

@Gabriel29306 c'est ça l'erreur que t'as rencontré pour le module incompatible ?

 (NOBRIDGE) ERROR  Invariant Violation: TurboModuleRegistry.getEnforcing(...): 'RNCWebView' could not be found. Verify that a module by this name is registered in the native binary.Bridgeless mode: true. TurboModule interop: true. Modules loaded: {"NativeModules":[],"TurboModules":["PlatformConstants","LogBox","SourceCode","AppState","BlobModule","WebSocketModule","DevSettings","DevToolsSettingsManager","Networking","Appearance","DevLoadingView","DeviceInfo","ImageLoader","SoundManager","IntentAndroid","DeviceEventManager","NativeReactNativeFeatureFlagsCxx","NativeAnimatedModule","I18nManager","ReanimatedModule","RNCAsyncStorage","RNGestureHandlerModule","StatusBarManager","StatusBarManager"],"NotFound":["NativePerformanceCxx","NativePerformanceObserverCxx","RedBox","BugReporting","HeadlessJsTaskSupport","LinkingManager","RNCSafeAreaContext","RNSModule","FrameRateLogger","KeyboardObserver","PlatformLocalStorage","RNC_AsyncSQLiteDBStorage","RNCWebView"]}
raphckrman commented 1 week ago

Cette PR est-elle utile puisque j'ai déjà fait la compatibilité vers SDK 52 d'Expo ? J'attend juste le fix d'un autre module pour PR sur Papillon. https://github.com/mrousavy/react-native-pressable-scale/pull/6

raphckrman commented 1 week ago

Si tu as besoin d'Expo 52 rapidement, tu peux regarder sur mon fork y'a une branch pour l'update et tu npm pack react-native-pressable-scale avec les modifications de ma PR

Gabriel29306 commented 1 week ago

@Gabriel29306 c'est ça l'erreur que t'as rencontré pour le module incompatible ?

 (NOBRIDGE) ERROR  Invariant Violation: TurboModuleRegistry.getEnforcing(...): 'RNCWebView' could not be found. Verify that a module by this name is registered in the native binary.Bridgeless mode: true. TurboModule interop: true. Modules loaded: {"NativeModules":[],"TurboModules":["PlatformConstants","LogBox","SourceCode","AppState","BlobModule","WebSocketModule","DevSettings","DevToolsSettingsManager","Networking","Appearance","DevLoadingView","DeviceInfo","ImageLoader","SoundManager","IntentAndroid","DeviceEventManager","NativeReactNativeFeatureFlagsCxx","NativeAnimatedModule","I18nManager","ReanimatedModule","RNCAsyncStorage","RNGestureHandlerModule","StatusBarManager","StatusBarManager"],"NotFound":["NativePerformanceCxx","NativePerformanceObserverCxx","RedBox","BugReporting","HeadlessJsTaskSupport","LinkingManager","RNCSafeAreaContext","RNSModule","FrameRateLogger","KeyboardObserver","PlatformLocalStorage","RNC_AsyncSQLiteDBStorage","RNCWebView"]}

Non, encore une autre

Gabriel29306 commented 1 week ago

Mais je suis parti sur la branche main du repo de Papillon

Kgeek33 commented 1 week ago

@raphckrman t'as fait également la transition du module QRCode vers Camera View?

raphckrman commented 1 week ago

j'ai tout fait 🤓 il était deprecated j'étais obligé

Kgeek33 commented 1 week ago

Alors fais ça et je closed :

Si tu veux que ncu soit en version interactive, ajoute -i. Si tu veux qu'il ignore des packages, ajoute -x (nom package)

J'utilise ncu et c'est extrêmement pratique :)

raphckrman commented 1 week ago

Pas de soucis je vais ajouter ça, le problème qui va être chiant c'est d'attendre que le mec merge ma PR pour fix le module incompatible..;

Kgeek33 commented 1 week ago

Tkt OK je closed