search

Parallels / vagrant-parallels

Vagrant Parallels Provider
https://parallels.github.io/vagrant-parallels
MIT License
996 stars 87 forks source link

Add a synced folder class for Mac VMs #448

Closed legal90 closed 1 year ago

legal90 commented 1 year ago

This is the alternative implementation of #446, which is supposed to fix the current issue of mounting synced folders on *.macvm guests: #445

Here I moved the synced folder support for *macvm to a separate class, SyncedFolderMacVM. ~It is just a placeholder for now and should still be filled with the proper implementation for macvms, as it was discussed here: https://github.com/Parallels/vagrant-parallels/pull/446#issuecomment-1554461800~

Fixes #445 Closes #446 as superseded

bineesh-n commented 1 year ago

Hi @legal90 , Thanks, this is ofcourse better implementation.

I've added enable / disable logic on top of your placeholder code. Tested the changes, working fine. If you are okay with the changes I added, we can merge this PR instead of #446

legal90 commented 1 year ago

Thank you, @bineesh-n ! Yes, feel free to merge this PR when you are ready. I can release a new version of vagrant-parallels later today.

legal90 commented 1 year ago

@bineesh-n I released it in v2.4.0 https://github.com/Parallels/vagrant-parallels/releases/tag/v2.4.0