search

ParitoshBh / grav-coder

https://paritoshbh.me
MIT License
28 stars 8 forks source link

Broken Post Navigation #18

Closed kkch closed 4 years ago

kkch commented 5 years ago

broken post navigation, prevSibling() and nextSibling() render current post url.

ParitoshBh commented 5 years ago

Can you please share Grav version you are using? How does a blog url looks like? And if possible your website url. I tested the theme on v1.6.17, v1.6.11 and the navigation is working as expected.

HymieAli commented 4 years ago

I am actually having the same issue. Tried upgading to the pre-release 1.7 version and it persisted as well. I have just unzipped a new install into the directory and configured the settings per the write up.

www.hymieali.com is the url, I can give you ftp access to the site if that helps Grav v1.6.19 - Admin v1.9.12 Grav-Coder theme 0.1.6

HymieAli commented 4 years ago

Did a little more testing to see if I could narrow it down a bit. Im not that fluent in the language but it was worth a try.

I took a peek at the pagination area {% if itemsInCollection > itemsPerPage %} , and tried adding the pages into a collection using a few methods as well as the @self.children and the call to page.prevSibling.url is still returning the current page.

I tried commenting out the if not page is Last/First to see if it would force it, but it didnt change so I reverted it.

I tried adding the call to page.adjacentSibling(-1) instead of the page.previous.sibling and opened a page in the middle of the collection. No change. I also tried page.prevSibling(page.path).title with no change. Since each of these are reliant on the collection feature working, perhaps there is something in my install that is failing to create them for this one folder. I will test a bit more and update if I get anywhere.

-Ali

Bobblejot commented 4 years ago

Hi did anyone discover the cause of this issue? i am having exactly the same problem. Previous and next links just link to the post your on.

HymieAli commented 4 years ago

I was not able to get it working myself. As a workaround I just have a block of text I put in at the end of each post that has a link to go back to the main blog listing.

Bobblejot commented 4 years ago

HymieAli - thanks for the reply been around the houses myself trying everything i could find without much luck, hopefully it will get fixed at some point.

ParitoshBh commented 4 years ago

Sorry guys, I have been busy with my day job recently. I have planned to devote some time for this bug today. Will update if more information is required.

ParitoshBh commented 4 years ago

@HymieAli

www.hymieali.com is the url, I can give you ftp access to the site if that helps Grav v1.6.19 - Admin v1.9.12 Grav-Coder theme 0.1.6

Will you be able to share the zip of your root directory or ftp access? I am not able to reproduce the problem both of you are facing and clearly there's something in your setup that isn't in mine.

HymieAli commented 4 years ago

you bet, fire me an email and Ill reply with some temp credentials to login via ftp hymie@hymieali.com

ParitoshBh commented 4 years ago

Sent you an email just now :)

ParitoshBh commented 4 years ago

Pushed release 0.1.7 hoping to fix this. Please update and test to see if fix works.

HymieAli commented 4 years ago

Pulled the zip file down, extracted it, renamed the old grav-coder to -old, put the new folder in place, re-enabled pagination in the grav-coder.yaml file, cleared cash and its working. Testing first/last page and they show a single arrow as expected and all the rest click to previous/next posts.

Nice!

ParitoshBh commented 4 years ago

Sweet! I'll close this issue then :)