search

Parth-Vader / YoutubeDataCollector

4 stars 4 forks source link

Added a Youtube Icon #13

Closed yashrsharma44 closed 6 years ago

yashrsharma44 commented 6 years ago

Actually I made a PR from master, so made a PR from non-master branch.

Parth-Vader commented 6 years ago

Looks cool. Can you also make the links clickable instead of the text?

yashrsharma44 commented 6 years ago

Okay. But I have to make a Seperate PR as it needs to include the recent commit #11

Parth-Vader commented 6 years ago

git pull and add to this PR itself.

yashrsharma44 commented 6 years ago

Thanks.

yashrsharma44 commented 6 years ago

Added the Hyperlink for the Videos.

yashrsharma44 commented 6 years ago

Can you close this PR, if everything is fine?

Parth-Vader commented 6 years ago

@yashrsharma44 Why do you want to close this PR? Do you not want this to be merged?

I tested it - but the Click To Open link doesn't seem to work.

yashrsharma44 commented 6 years ago

Sorry for that. I need to address some issues regarding the link, so I will correct it now.

yashrsharma44 commented 6 years ago

I am not able to save the changes in this PR, so I need to close this PR and make a new PR. Please consider that.