search

Particular / NServiceBus.Transport.AzureServiceBus

Azure Service Bus transport
Other
22 stars 19 forks source link

Stop pumps on shutdown #1094

Closed danielmarbach closed 3 weeks ago

danielmarbach commented 3 weeks ago

This aligns the transport to stop the pumps on transport shutdown and at the same time makes sure the pumps stop method can be called multiple times.

This is part of addressing some low-hanging fruit to align all transports for the transport seam usage scenarios to make sure pumps are stopped when the transport shuts down.

I have tried to write a transport test for it to enforce it eventually for all transport but couldn't find a way to do that without introducing flags on the transport interface and using fancy techniques like default members which seams overkill

SeanFeldman commented 3 weeks ago

I have tried to write a transport test for it to enforce it eventually for all transport but couldn't find a way to do that without introducing flags on the transport interface and using fancy techniques like default members which seams overkill

Could just say "Testing will be performed using PUnit".