PascalGameDevelopment / SDL2-for-Pascal

Unit files for building Free Pascal and Delphi applications using the SDL2 library
https://pascalgamedevelopment.github.io/SDL2-for-Pascal/
Mozilla Public License 2.0
103 stars 20 forks source link

sdlkeycode.inc: SDLK_QUOTE = TSDL_KeyCode('\'); is wrong. #136

Closed Chixpy closed 6 months ago

Chixpy commented 6 months ago

Hi. It's a simple mistake.

In line 37 of sdlkeycode.inc

SDLK_QUOTE = TSDL_KeyCode('\');

must be

SDLK_QUOTE = TSDL_KeyCode('''');

Backslash \ key is defined in line 67: SDLK_BACKSLASH = TSDL_KeyCode('\');

Actually, SDLK_QUOTE was renamed three week ago to SDLK_APOSTROPHE, but I'think that it's for SDL3

Free-Pascal-meets-SDL-Website commented 6 months ago

Never noticed this, thanks!

Can you craft a quick patch/PR or should I do it?

Best regards

Chixpy commented 6 months ago

Done #137

suve commented 6 months ago

Oh oops. Thanks for noticing and thanks for the PR.