Convert Arrays to string in Simulation Parameters - Githubissues

PathmindAI / nativerl

Train reinforcement learning agents using AnyLogic or Python-based simulations

Apache License 2.0

19 stars 4 forks source link

Convert Arrays to string in Simulation Parameters #496

Closed ejunprung closed 2 years ago

ejunprung commented 2 years ago

fionnachan commented 2 years ago

Looks like it's this line from NativeRL that caused this to be shown. https://github.com/SkymindIO/nativerl/pull/369/files#diff-eb7326a7378b37453f20264fc5062c7983d8141b290bfa1374da18c4a8616fdfR61

https://github.com/SkymindIO/nativerl/issues/360#issuecomment-902338454 Since we don't support Arrays, now Arrays are just turned into String values by value.toString() like other types. NativeRL will need to support this type specifically to make it work.

On the webapp we are just displaying the value straight from the simulation parameter DB table record value column for others type https://github.com/SkymindIO/pathmind-webapp/blob/4e345de859a42a849bb039592fa5554feaeb783e/pathmind-webapp/src/main/java/io/skymind/pathmind/webapp/ui/components/simulationParameters/SimulationParametersRowField.java#L111-L114

ejunprung commented 2 years ago

Ah, I see. I don't think this is common so I guess we can ignore for now. Doesn't seem worth the effort.