search

Patrick-Hogan / wandering_inn

Download and convert The Wandering Inn to epub and mobi (kindle) format
27 stars 16 forks source link

Fix 404 errors downloading images #22

Closed JJTech0130 closed 10 months ago

JJTech0130 commented 1 year ago

This should fix a weird issue that appears on Python 3.9 causing it to return a 404 All it does is configures urllib to use the default SSL context. Not sure if wanderinginn.com is doing TLS fingerprinting, or if it is just a weird TLS configuration thing. I can't properly debug it because using a SSL proxy like Fiddler fixes the issue... (Fix #20)

JJTech0130 commented 1 year ago

I also increased the timeout from 5 seconds to 10 seconds. 5 seconds was short enough that large images would sometimes time out in the process of downloading.

Patrick-Hogan commented 10 months ago

I've still never hit that issue, but I finally got around to testing that the fix you provided does no harm to users that aren't having a problem, so I've merged the fix in.