search

PatrickAlphaC / brownie_fund_me

26 stars 64 forks source link

test_only_owner_can_withdraw() doesnt work with Ganache UI v2.5.4 #43

Closed damdafayton closed 2 years ago

damdafayton commented 2 years ago

This is just to inform future learners to save them time;

As title says the test functiontest_only_owner_can_withdraw() in this tutorial doesnt work in Ganache UI, and gives this error:

E           ValueError: Execution reverted during call: 'VM Exception while processing transaction: revert'. This transaction will likely revert. If you wish to broadcast, include `allow_revert:True` as a transaction parameter.

Based on the comment here Ive found out that it works with ganache-cli.

PatrickAlphaC commented 2 years ago

Oh wow.. Thanks for this! Could you make a PR to the readme with this information?

damdafayton commented 2 years ago

Oh wow.. Thanks for this! Could you make a PR to the readme with this information?

@PatrickAlphaC sure, I'll do it when I have some available time.

damdafayton commented 2 years ago

Hi @PatrickAlphaC, here is the PR

PatrickAlphaC commented 2 years ago

Thank you!

Fixed in https://github.com/smartcontractkit/full-blockchain-solidity-course-py/pull/1516