search

PatrickJS / angular-md5

md5 for Angular.js and Gravatar filter
MIT License
132 stars 55 forks source link

Update angular-md5.js #1

Closed azzamallow closed 10 years ago

azzamallow commented 10 years ago

Ensure if the text passed through the filter is actually a Number that it will be converted into a String.

azzamallow commented 10 years ago

Could you also bump the version so I can import this into my project as a bower dependency?

PatrickJS commented 10 years ago

thanks!

PatrickJS commented 10 years ago

@azzamallow let me know if everything is working correctly. If you have any other ideas I can add them

azzamallow commented 10 years ago

@gdi2290 Could you update the version so i can bower install the latest?

PatrickJS commented 10 years ago

@azzamallow oops I forgot to git push the tags

azzamallow commented 10 years ago

I have a question about the createHash method in general. Is the input required to be a string? Or do you think it is worth converting to a string within the method. For example

md5.createHash(item.id) // item.id === 5

This currently breaks as the method expects the value to be a string.