Patryk27 / kartoffels

a game where you're given a potato and your job is to implement a firmware for it
https://kartoffels.pwy.io
GNU General Public License v3.0
240 stars 6 forks source link

Name bots and persisted top scoring of day #36

Open kriskw1999 opened 2 months ago

kriskw1999 commented 2 months ago

Hi, first of all thanks cause you've made my day with this game!

It would be nice to be able to define the name of the bot to be placed instead of the id.

Another cool feature would be a persistent ranking of best bots and not just the alive ones. (also a window of the best ones would be cool like best 10 or 100 instead of keeping them all).

If you appreciate any of these ideas I can dedicate some spare time on trying to add these features or help in any way.

Anyway let me know what do you think! 🚀

Patryk27 commented 2 months ago

Hi, thanks for the ideas!

It would be nice to be able to define the name of the bot to be placed instead of the id.

I'm a bit wary on allowing to provide custom names, because that would most likely require a moderation mechanism sooner or later - but I was thinking about allowing to build a name out of a preconfigured dictionary of words, that could be the best of both worlds.

(you could argue that allowing to see the serial port of non-your bots poses the same issue, but the serial port is less dangerous, since you can't see it directly on the bot list under [b], so its potential damage is limited, imo)

Another cool feature would be a persistent ranking of best bots and not just the alive ones. (also a window of the best ones would be cool like best 10 or 100 instead of keeping them all).

Yes, the scoring system definitely needs to get better. Allowing to see the best scores from a couple of windows - like the last 1h, 12h, 24h, 2d etc. - is on my list 🙂

If you appreciate any of these ideas I can dedicate some spare time on trying to add these features or help in any way.

Thanks, but currently the code is still in a lot of motion, so to say, with refactorings happening all over the place, and I just wouldn't want for you to start working on something that would get very difficult to merge/rebase later - I'll see what I can implement and ping you back if there's something I could use some help with.

If you have any more ideas, feel free to note them down!

kriskw1999 commented 2 months ago

Sounds great, thanks for the fast reply!