search

Pauan / tab-organizer

Google Chrome Extension that makes it easier to manage many tabs!
MIT License
63 stars 8 forks source link

Using macros can sometimes cause one or more windows to be closed! #116

Closed Pauan closed 9 years ago

Pauan commented 9 years ago

Originally reported on Google Code with ID 114

What steps will reproduce the problem?
1. Create some macro rules that move tabs around, like "require".
2. Apply the rules using "Apply all macros".

What is the expected output? What do you see instead?
Should work correctly. Instead, sometimes some of the tabs will be closed! What's worse,
there doesn't seem to be a way to undo this...

Please provide any additional information below.
Permanent data loss, and not just a couple tabs, either. I lost something like 60+
tabs this way.

The problem is, that I haven't been able to reproduce it yet... I've used macros a
lot, and haven't had a problem with them, then suddenly BAM this issue pops up.

It may have to do with the asynchronousness in Chrome's APIs. We'll see. In any case,
this is a huge issue and I really need to dig in and find a way to reproduce it.

Reported by pcxunlimited on 2010-12-16 09:56:40

Pauan commented 9 years ago 
I think it may be caused by session restore or something? It seemed to me that this
problem occurs shortly after restoring tabs from a previous session, but only occurs
once per session. i.e. after the first time this happens, it won't happen again until
you restart Chrome.

Reported by pcxunlimited on 2010-12-16 09:59:08

Pauan commented 9 years ago 
I just had this happen again. I restarted Chrome, browsed some sites for a while, then
hit "Apply all macros..." which caused about 196 tabs to be closed. They appeared on
the New Tab page, though, so I could have restored them if I wanted to.

In the console, I got a lot of messages like this:

Error during tabs.get: No tab with id: 3293. chrome/ExtensionProcessBindings:87

The tab id differs, but the message is otherwise identical. There appears to be one
message per tab that was "closed". Definitely looks like some sort of async issue...

I need to set up a simple test-case so I can reproduce this issue.

Reported by pcxunlimited on 2010-12-29 08:22:10

Pauan commented 9 years ago

Reported by pcxunlimited on 2011-01-16 17:39:58

Pauan commented 9 years ago 
After the Platform overhaul, I haven't noticed this issue again. There was a weird issue
that came up involving Macros, but it seems to have fixed itself somehow. I'm still
keeping an eye on this, though, since I'm not sure if it's fixed or not.

Reported by pcxunlimited on 2011-01-20 00:09:05

Pauan commented 9 years ago 
Scratch that, I just had it happen again. This could be really hard to debug...

Reported by pcxunlimited on 2011-01-20 00:12:31

Pauan commented 9 years ago 
Alright, I think I fixed it with revision 588f65822f. But I'll keep an eye on it for
a while before I mark this bug as fixed, just in case.

Reported by pcxunlimited on 2011-01-22 06:12:33

Pauan commented 9 years ago 
For future reference, assuming this was actually fixed, it was fixed for the 3.6 release.

Reported by pcxunlimited on 2011-01-29 10:26:52

Pauan commented 9 years ago 
I haven't noticed this issue anymore, and in addition, the version 5 rewrite will likely
have issues of its own, so I'm going to close this.

Reported by pcxunlimited on 2012-08-27 22:24:50

Pauan commented 9 years ago

Reported by pcxunlimited on 2012-08-27 23:44:48