search

Pavliko / postcss-svg

PostCSS plug-in which to insert inline SVG to CSS and allows you to manage it colors.
http://pavliko.github.io/postcss-svg/
Creative Commons Zero v1.0 Universal
124 stars 23 forks source link

Pin dependencies #26

Closed kvz closed 8 years ago

kvz commented 8 years ago

This helps against things suddenly exploding in your face, such as our deploys today because xmldom slipped a not-so-backwards-compatible update in a patch version. Who can blame them, it's impossible to know all the different ways people are using your project and what effects a minor change might have, and how that might break things in subtle or not so subtle ways for them.

Long story short, let's pin dependencies so any change is explicit & tested, and our builds and deploys are reproducible.

See https://github.com/Pavliko/postcss-svg/issues/25

sbstnmsch-zz commented 8 years ago

This fixes #25 for me. +1 for merging this into 1.0.5

Pavliko commented 8 years ago

Thank you for your job 👍

sbstnmsch-zz commented 8 years ago

Just my recommendation - using travis-ci together with greenkeeper.io will automagically test and PR when new versions arrive on NPM - keeping everything green and up-to-date. Maybe i have time to spent on this.