search

Pearson-Higher-Ed / o-contextual-help

DEPRECATED - Contextual help for web applications
https://origami.pearsoned.com/registry/components/o-contextual-help
1 stars 0 forks source link

embedapi script link in demo should be relative instead of registry.origami.ft.com #4

Open pawosty opened 9 years ago

pawosty commented 9 years ago

I happened to notice when taking a look at the demo for this component that the demo is trying to load a script at registry.origami.ft.com (https://github.com/Pearson-Higher-Ed/o-contextual-help/blob/master/demos/demo.html#L155):

<script src="//registry.origami.ft.com/embedapi?autoload=resize"></script>

This causes loading the script to fail because registry.origami.ft.com doesn't accept https, while the registry applicaiton in all Pearson environments is https-only.

Fixing should be easy since the route exists on the Pearson registry as well (https://origami.pearsoned.com/registry/embedapi?autoload=resize):

<script src="//registry/embedapi?autoload=resize"></script>

aarmour commented 9 years ago

I've been using a simple script to fix the demos, which are generated by origami-build-tools.

pawosty commented 9 years ago

Cool. I wasn't aware OBT was generating the bad links, actually, good to know.