search

Pecacheu / Elevators-v2

Adds fully-featured Elevators to Minecraft!
GNU General Public License v3.0
10 stars 10 forks source link

I add some code to fix bugs #2

Closed xaxys closed 6 years ago

xaxys commented 6 years ago

I add some method and variable, i add "//新增" before them Some tips are written by chinese, but you can translate them by google translation easily I think maybe there are some error in ChuList, such as length is always 1? I'm not sure maybe you can write a hash map to to hash the world and some coordinate, avoid erdodic all elevator when check a sign, make plugin more efficient

I solved there problem: Prevent cheating by Breaking block Prevent cheating by Using piston to steal block Prevent cheating by Breaking the block behind wall_sign to cause error Prevent cheating by Making elevator repeatedly to get glass panel Haven't complete the function that prevent cheating by automatically generating a new floor after the player has removing a floor

I'm not sure when you remove the floor when player remove a storey(after i remove the code to prevent player from falling by generate a floor), can you explain that to me?

I'm sorry I have poor english and I'm not familiar with Github, XD

Pecacheu commented 6 years ago

Your pull-request had some formatting issues but I copied the changed code into the original files to test.

I've made some changes and finished the code to prevent floor griefing. I also removed the piston protection part, because the other code seems to stop pistons as well. Also, to fix the issue involving the block that gets placed under you when deleting a floor, I changed it to a dirt block, so it should be pretty useless.

I'll post the new files after merging the pull request.