Resolved column validation (Issue #74)

PecanProject / BETYdb-YABA

Yet Another BETYdb API (for metadata upload)

BSD 3-Clause "New" or "Revised" License

5 stars 18 forks source link

Resolved column validation (Issue #74) #81

Closed eshantri closed 3 years ago

eshantri commented 3 years ago

Screenshot from 2021-03-01 10-20-18 In order to test this I removed "start_date" column from "input_files/experiments.csv" file and ran curl -F "fileName=@input_files/experiments.csv" \ http://localhost:5001/yaba/v1/experiments?username=guestuser , as expected it gave the following error- I tested the same on other routes as well and all gave expected errors on missing the required columns.

dlebauer commented 3 years ago

Thanks @eshantri !!

im-prakher commented 3 years ago

@dlebauer The linter test was first failing for this pull request whereas when I reverted this pr, the tests were running fine. Also, I created an empty test commit that was running fine on my forked repository but the same error occurred when I created the pr on YABA repo. Take a look at #88

im-prakher commented 3 years ago

Is it possible, since the forked repo eshantri:master has been deleted, it might be creating trouble for upcoming PR's after this?

dlebauer commented 3 years ago

Certainly possible - but I think it is always okay to delete a branch after it has been merged.

it seemed to also be complaining about a missing commit / incomplete git history in the PR.